When launching core list with no installed platforms print no platforms installed
#2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2238 +/- ##
==========================================
- Coverage 63.02% 62.98% -0.05%
==========================================
Files 220 220
Lines 19499 19506 +7
==========================================
- Hits 12290 12286 -4
- Misses 6128 6136 +8
- Partials 1081 1084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MatteoPologruto
approved these changes
Jul 4, 2023
per1234
added
topic: code
alessio-perugini
deleted the
2220-ae-111-core-list-command-gives-no-output-when-no-platforms-are-installed
branch
alessio-perugini
changed the title
core list with no installed platforms show table headerscore list with no installed platforms print no platforms installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
core listcommand now prints the table headers in the stdout when no platforms are installedWhat is the current behavior?
Empty stdout. The only case we show something is when we set the json format flag it returns
[]What is the new behavior?
The new behavior if no platforms are installed prints only the table headers.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
The other option we have is to show something like this: